Skip to content

Conversation

CTGM-Bixal
Copy link
Contributor

@CTGM-Bixal CTGM-Bixal commented Aug 25, 2024

Summary

This PR provides a changelog entry for the updates made to the pagination component. The text-decoration styles has been removed so that the pagination page numbers show up as links.

Related issue

USWDS - Pagination: Updated text-decoration value to better show pagination links #5970

Preview link

Preview link:
Pagination - Latest Updates

@CTGM-Bixal CTGM-Bixal requested a review from mahoneycm August 26, 2024 15:47
Copy link
Contributor

@cathybaptista cathybaptista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @RachelCorsino

LGTM, I see that it is no longer a breaking change and that summaryAdditional: Link styles are now visually consistent with usa-link.

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended some small tweaks for clarity. Thanks for setting this up!

@CTGM-Bixal CTGM-Bixal requested a review from amyleadem August 26, 2024 22:53
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mahoneycm mahoneycm requested review from thisisdano and removed request for mejiaj August 28, 2024 14:13
@mahoneycm mahoneycm changed the base branch from main to release-3.9.0 September 3, 2024 17:35
affectsStyles: true
githubPr: 5970
githubRepo: uswds
versionUswds: N.N.N
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Update version to 3.9.0 before merge

@CTGM-Bixal CTGM-Bixal changed the title Changelog: Text-Decoration Style Fix for Pagination Component Accessibility USWDS-Site: Add changelog for text-decorstion style fix for pagination component [#5970] Sep 4, 2024
@mejiaj mejiaj changed the title USWDS-Site: Add changelog for text-decorstion style fix for pagination component [#5970] USWDS-Site: Add changelog for text-decoration style fix for pagination component [#5970] Oct 1, 2024
@amyleadem amyleadem merged commit 6d0f837 into release-3.9.0 Oct 3, 2024
9 of 11 checks passed
@amyleadem amyleadem deleted the rc-changelog-pagination-5970 branch October 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants