-
Notifications
You must be signed in to change notification settings - Fork 195
USWDS-Site: Add changelog for text-decoration style fix for pagination component [#5970] #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @RachelCorsino
LGTM, I see that it is no longer a breaking change and that summaryAdditional: Link styles are now visually consistent with usa-link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommended some small tweaks for clarity. Thanks for setting this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
affectsStyles: true | ||
githubPr: 5970 | ||
githubRepo: uswds | ||
versionUswds: N.N.N |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Update version to 3.9.0
before merge
Summary
This PR provides a changelog entry for the updates made to the pagination component. The text-decoration styles has been removed so that the pagination page numbers show up as links.
Related issue
USWDS - Pagination: Updated text-decoration value to better show pagination links #5970
Preview link
Preview link:
Pagination - Latest Updates