Skip to content

Changelog: Memorable Date remove numeric months [#6028] #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 3, 2024
Merged

Changelog: Memorable Date remove numeric months [#6028] #2787

merged 5 commits into from
Oct 3, 2024

Conversation

cathybaptista
Copy link
Contributor

@cathybaptista cathybaptista commented Aug 21, 2024 •
edited
Loading

Summary

Changelog for uswds/uswds#6028

Related PR

uswds/uswds#6028

Preview link

Form component changelog →

@cathybaptista cathybaptista changed the title Added changelog for PR 5910 memorable date Changelog for PR 5910 memorable date Aug 21, 2024
@cathybaptista cathybaptista changed the title Changelog for PR 5910 memorable date Changelog: Memorable Date remove numeric months [#5910] #5910 Aug 21, 2024
@cathybaptista cathybaptista changed the title Changelog: Memorable Date remove numeric months [#5910] #5910 Changelog: Memorable Date remove numeric months [#5910] Aug 21, 2024
@cathybaptista cathybaptista changed the title Changelog: Memorable Date remove numeric months [#5910] Changelog: Memorable Date remove numeric months [#6028] Aug 21, 2024
@cathybaptista cathybaptista mentioned this pull request Aug 21, 2024
Merged
@cathybaptista cathybaptista marked this pull request as ready for review August 21, 2024 23:07
mejiaj
mejiaj reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cathybaptista minor suggestion, but looks great. Thanks!

mahoneycm
mahoneycm reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of optional copy changes for ya!

I agree with @mejiaj about adding the affects: markup tag.

amyleadem
amyleadem suggested changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks good! Can you remove the empty file tagged in the comment below?

amyleadem
amyleadem reviewed Aug 26, 2024
View reviewed changes
@cathybaptista cathybaptista force-pushed the cb-changelog-6028 branch 2 times, most recently from af180af to f385908 Compare August 26, 2024 19:12
mahoneycm
mahoneycm approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mahoneycm mahoneycm changed the base branch from main to release-3.9.0 September 3, 2024 21:03
amyleadem
amyleadem approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyleadem amyleadem changed the base branch from release-3.9.0 to main September 6, 2024 22:38
@amyleadem amyleadem changed the base branch from main to release-3.9.0 September 6, 2024 22:38
@mahoneycm mahoneycm mentioned this pull request Sep 18, 2024
Merged
3 tasks
@amyleadem amyleadem requested review from thisisdano and removed request for mejiaj and CTGM-Bixal September 30, 2024 23:09
@mejiaj mejiaj self-requested a review October 1, 2024 15:43
@amyleadem amyleadem merged commit 5080ed6 into release-3.9.0 Oct 3, 2024
6 of 8 checks passed
@amyleadem amyleadem deleted the cb-changelog-6028 branch October 3, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisdano thisisdano Awaiting requested review from thisisdano

3 more reviewers

@mejiaj mejiaj mejiaj approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

@amyleadem amyleadem amyleadem approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cathybaptista @mejiaj @mahoneycm @amyleadem