USWDS-Site - Footer: Create footer accessibility test page #2760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahoneycm
commented
Jul 30, 2024
_data/accessibility-tests/footer.yml
Outdated
Comment on lines
23
to
28
| - summary: Footer icons and non-text content meet color contrast requirements. | ||
| summary_additional: When you use a color contrast checker to view the footer, contrast between the icon or other non-text elements and adjacent colors is at least 3:1. | ||
| test_status: pass | ||
| test_type: general | ||
| version_tested: 3.8.1 | ||
| wcag_criterion: 1.4.11 |
There was a problem hiding this comment.
note: This was originally listed in the checklist as 1.4.3. I updated in both locations to appropriately target 1.4.11, non-text color contrast
mahoneycm
commented
Jul 30, 2024
amyleadem
suggested changes
Jul 30, 2024
There was a problem hiding this comment.
Thanks for building this so quickly @mahoneycm. I added some comments below. Hopefully they are all pretty quick to resolve. Let me know if you have any questions.
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
…e into cm-a11y-checklist-footer
mahoneycm
commented
Aug 1, 2024
amyleadem
suggested changes
Aug 1, 2024
There was a problem hiding this comment.
Looking good! Thanks for addressing all of that. I added just one outstanding comment about next steps for 1.3.5. Let me know if you have questions!
Edit: I also left a comment about the icon color contrast, but need additional input from @amycole501 and @alex-hull.
amyleadem
suggested changes
Aug 5, 2024
amycole501
approved these changes
Aug 5, 2024
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
amyleadem
suggested changes
Aug 6, 2024
amyleadem
approved these changes
Aug 6, 2024
5 tasks
thisisdano
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added accessibility tests page for the footer component.
Important
We should update the changelog dates before merge.
Related issue
Closes #2740 & #2457
Preview link
Resources
Testing and review
2.4.4wcag criterion is accurate and link works