USWDS-Site: Add changelog for alert alignment fix [#5636] #2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2024 09:18
3 tasks
added 2 commits
September 30, 2024 13:03
…nto al-changelog-5636
mejiaj
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Thanks @amyleadem. Added small suggestions for plain language.
package.json
Outdated
| @@ -98,6 +98,6 @@ | |||
| "snyk": true, | |||
| "dependencies": { | |||
| "@uswds/compile": "1.2.0", | |||
| "@uswds/uswds": "3.8.2" | |||
| "@uswds/uswds": "github:uswds/uswds#al-alert-icon-alignment" | |||
There was a problem hiding this comment.
issue: We should revert this change.
There was a problem hiding this comment.
Leaving it in for now while uswds/uswds#5636 is still in review. This way we can provide a demo of the on site.
Co-authored-by: James Mejia <james.mejia@gsa.gov>
Co-authored-by: James Mejia <james.mejia@gsa.gov>
Co-authored-by: James Mejia <james.mejia@gsa.gov>
Co-authored-by: James Mejia <james.mejia@gsa.gov>
|
Suggestions look good @mejiaj. Ready for your re-review |
mejiaj
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a changelog for PR #5636
Important
We need to update the changelog dates before merge.
Important
We need to update uswds branch before merge.DoneRelated issue
Related to uswds/uswds#5636
Preview link