-
Notifications
You must be signed in to change notification settings - Fork 196
USWDS-Site - Changelog: Character count visual cues [#5908] #2648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahoneycm this looks good, but again, only have a question... should it already have the versionUswds?
Also, it appears there is a merge conflict on this branch
@cathybaptista Merge conflict resolved! I also went ahead and removed the USWDS version number for now 👍 |
cathybaptista
approved these changes
Sep 5, 2024
amyleadem
reviewed
Sep 9, 2024
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
cathybaptista
approved these changes
Sep 16, 2024
3 tasks
amyleadem
reviewed
Sep 30, 2024
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
mejiaj
approved these changes
Oct 1, 2024
amyleadem
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds changelog for uswds/uswds#5908
Related PR
USWDS - Character count: Enhance visual cue when limit is exceeded #5908
Preview link
Preview →