-
Notifications
You must be signed in to change notification settings - Fork 195
USWDS-Site - Changelog: Datepicker mouseover
behaviors [#5774]
#2496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mouseover
behaviors[#]mouseover
behaviors[#5778]
mouseover
behaviors[#5778]mouseover
behaviors[#5774]
mouseover
behaviors[#5774]mouseover
behaviors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahoneycm thanks for adding the changelog info.
I've removed the feature PR number in title to avoid confusion.
@mejiaj Updated the summaries to match you recommendation! RE: the USWDS PR number in the title, we've generally been doing this to make it easier to track the related PRs/Changelogs between repos. Personally, I like it when it comes to gather for release documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahoneycm This looks great, but I'm just being picky about this line: Fixed a bug that caused mouseover
events to focus buttons and prevent keyboard navigation.
So the bug was that when the mouseover event got triggered, it caused the focus to be on the buttons and also prevented keyboard navigation? What about something like this: "fixed a bug that caused mouseover events to focus "on" buttons and prevent keyboard navigation. Or, "fixed a bug that caused mouseover events to "shift focus to" buttons and prevent keyboard navigation." :)
mouseover
behaviorsmouseover
behaviors [#5774]
@mahoneycm thanks for the updates and the info on the PR numbers. If it helps then let's keep. |
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
…nto cm-changelog-5778
…nto cm-changelog-5778
Summary
Create changelog entries for date picker and date range picker for uswds/uswds#5774
Related PR
uswds/uswds#5774
Preview link
Date picker changelog →
Date range picker changelog →