Skip to content

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Feb 20, 2024

Summary

Create changelog entries for date picker and date range picker for uswds/uswds#5774

Related PR

uswds/uswds#5774

Preview link

Date picker changelog →

Date range picker changelog →

@mahoneycm mahoneycm changed the title USWDS-Site - Changelog: Datepicker mouseover behaviors[#] USWDS-Site - Changelog: Datepicker mouseover behaviors[#5778] Mar 22, 2024
@mahoneycm mahoneycm changed the title USWDS-Site - Changelog: Datepicker mouseover behaviors[#5778] USWDS-Site - Changelog: Datepicker mouseover behaviors[#5774] Jul 22, 2024
@mejiaj mejiaj changed the title USWDS-Site - Changelog: Datepicker mouseover behaviors[#5774] USWDS-Site - Changelog: Datepicker mouseover behaviors Jul 23, 2024
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahoneycm thanks for adding the changelog info.

I've removed the feature PR number in title to avoid confusion.

@mahoneycm
Copy link
Contributor Author

@mejiaj Updated the summaries to match you recommendation!

RE: the USWDS PR number in the title, we've generally been doing this to make it easier to track the related PRs/Changelogs between repos. Personally, I like it when it comes to gather for release documentation.

image

@mahoneycm mahoneycm changed the base branch from main to release-3.9.0 September 3, 2024 21:05
Copy link
Contributor

@cathybaptista cathybaptista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahoneycm This looks great, but I'm just being picky about this line: Fixed a bug that caused mouseover events to focus buttons and prevent keyboard navigation.

So the bug was that when the mouseover event got triggered, it caused the focus to be on the buttons and also prevented keyboard navigation? What about something like this: "fixed a bug that caused mouseover events to focus "on" buttons and prevent keyboard navigation. Or, "fixed a bug that caused mouseover events to "shift focus to" buttons and prevent keyboard navigation." :)

@mahoneycm mahoneycm changed the title USWDS-Site - Changelog: Datepicker mouseover behaviors USWDS-Site - Changelog: Datepicker mouseover behaviors [#5774] Sep 5, 2024
@mejiaj
Copy link
Contributor

mejiaj commented Sep 7, 2024

@mahoneycm thanks for the updates and the info on the PR numbers. If it helps then let's keep.

Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@amyleadem amyleadem requested review from thisisdano and removed request for CTGM-Bixal September 30, 2024 23:15
@amyleadem amyleadem merged commit 4b9ea04 into release-3.9.0 Oct 4, 2024
6 of 8 checks passed
@amyleadem amyleadem deleted the cm-changelog-5778 branch October 4, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants