Skip to content

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Feb 20, 2024

Summary

Added changelog entry for Documentation page template update.

Related issue

Part of #2477. Related to uswds/uswds#5794 and uswds/uswds#5809.

Preview link

Preview link →

Changelog should appear in sidenav & bottom of the page.

@mejiaj mejiaj marked this pull request as ready for review February 20, 2024 19:34
@mejiaj mejiaj requested a review from amyleadem February 20, 2024 19:34
@thisisdano
Copy link
Contributor

I'm adding a Hold label to this PR while we work through uswds/uswds#5681

My comments on the related PR: uswds/uswds#5681 (comment)

@mahoneycm
Copy link
Contributor

mahoneycm commented Mar 1, 2024

Update 3/1/24

Updated to reflect alternate solution uswds/uswds#5794

@mejiaj
Copy link
Contributor Author

mejiaj commented Mar 6, 2024

Removing hold; there's a new solution in uswds/uswds#5794.

Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
@mahoneycm mahoneycm requested a review from amyleadem March 6, 2024 15:16
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @mahoneycm.
I had one question about considering this a breaking change. Let me know what you think!

Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com>
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thisisdano thisisdano merged commit de14f27 into release-3.8.0 Mar 11, 2024
@thisisdano thisisdano deleted the jm-changelog-doc-template branch March 11, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants