Skip to content

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Oct 19, 2023

Summary

Add changelog entry for range slider SR enhancement

Related PR

uswds/uswds#5472

Preview link

Guidance and changelog →

@mahoneycm mahoneycm requested review from mejiaj and amyleadem October 26, 2023 18:12
@amyleadem amyleadem changed the base branch from main to release-3.7.0 October 27, 2023 21:35
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the table! I added a few suggestions for clarity. Let me know if you have questions!

@mahoneycm mahoneycm requested a review from amyleadem November 1, 2023 20:12
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahoneycm Generally looking good! After thinking about some of the items a bit more, I added a couple more suggestions.

@mahoneycm mahoneycm requested a review from amyleadem November 6, 2023 16:56
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @mahoneycm

@amyleadem amyleadem merged commit cbb46ec into release-3.7.0 Nov 6, 2023
@mejiaj mejiaj deleted the cm-changelog-5472 branch February 21, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants