Skip to content

Conversation

mejiaj
Copy link
Contributor

@mejiaj mejiaj commented Oct 11, 2023

Summary

Added changelog entry to banner.

Related issue

Changelog for uswds/uswds#5551

Preview link

Preview link: TK

Testing and review

  • Zero regressions in Banner & accordion (especially event conflicts).
  • Changelog entry exists for this feature.
  • Zero webdev console errors.

Todo

  • Update changelog date & USWDS version.
  • Restore USWDS version in package.json.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Update date & versionUswds fields.

package.json Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo

Restore USWDS version.

@amyleadem amyleadem changed the base branch from main to release-3.7.0 October 27, 2023 21:01
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyleadem amyleadem marked this pull request as ready for review October 31, 2023 21:19
@amyleadem amyleadem merged commit 94a434c into release-3.7.0 Oct 31, 2023
@mejiaj mejiaj deleted the jm-feature-banner-init branch November 8, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants