USWDS-Site - Changelog: Identifier screen reader update [#5491] #2266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahoneycm
approved these changes
Oct 30, 2023
| @@ -2,6 +2,14 @@ title: Identifier | |||
| type: component | |||
| changelogURL: | |||
| items: | |||
| - date: NNNN-NN-NN | |||
| summary: Updated the screen reader readout to say "Official" instead of "An official". | |||
| summaryAdditional: Users should update their markup to improve the screen reader experience. | |||
There was a problem hiding this comment.
Optional change
Should we highlight why we made the change? Something like:
Suggested change
| summaryAdditional: Users should update their markup to improve the screen reader experience. | |
| summaryAdditional: This change prevents screen reader users from mishearing "Unofficial" instead of "An official". Users should update their markup to improve the screen reader experience. |
Feel free to change the language.
There was a problem hiding this comment.
Good note. I updated it to be more similar to both the release notes and the related banner changelog (issue #5925).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add changelog entry for identifier screen reader copy edit.
Related PR
uswds/uswds#5491
Preview link
Identifier changelog