Skip to content

USWDS-Site - Changelog: In-page nav header selector [#5444] #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 29, 2024
Merged

USWDS-Site - Changelog: In-page nav header selector [#5444] #2252

merged 12 commits into from
Feb 29, 2024

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Aug 17, 2023 •
edited
Loading

Summary

Preview link

Problem statement

PR uswds/uswds#5444 added a new data attribute that should be added to the documentation.

Testing and review

In both the properties table and changelog, confirm:

  • Grammar and spelling
  • The updated information is accurate

@amyleadem amyleadem changed the base branch from main to al-changelog-5387 August 17, 2023 21:22
Base automatically changed from al-changelog-5387 to release-3.6.0 August 18, 2023 17:42
@amyleadem amyleadem mentioned this pull request Aug 22, 2023
Merged
@amyleadem amyleadem changed the base branch from release-3.6.0 to main August 23, 2023 22:45
@amyleadem amyleadem marked this pull request as ready for review August 23, 2023 23:09
@amyleadem amyleadem requested review from mejiaj and mahoneycm August 23, 2023 23:09
@amyleadem amyleadem marked this pull request as draft September 26, 2023 17:43
@amyleadem
Copy link
Contributor Author

Putting this in draft because I need to make additional edits to other h2 and h3 references the guidance .

@amyleadem amyleadem marked this pull request as ready for review September 27, 2023 21:17
mahoneycm
mahoneycm reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just flagging a potential visual quirk on the properties table

@mahoneycm mahoneycm mentioned this pull request Feb 1, 2024
Closed
5 tasks
@amyleadem amyleadem changed the base branch from main to release-3.8.0 February 20, 2024 19:25
@amyleadem amyleadem requested a review from mahoneycm February 28, 2024 18:16
@amyleadem amyleadem mentioned this pull request Feb 28, 2024
Merged
mahoneycm
mahoneycm approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Wasn't able to view the final output due to the build failing for some reason, but the code matches the expected pattern and should output as expected 👍

Important

We should ensure build before final merge

@amyleadem amyleadem merged commit 7bc4801 into release-3.8.0 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejiaj mejiaj Awaiting requested review from mejiaj

1 more reviewer

@mahoneycm mahoneycm mahoneycm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyleadem @mahoneycm