USWDS-Site: Changelog for #5413 #2220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
amyleadem
suggested changes
Sep 15, 2023
Comment on lines
6
to
8
| summary: Removed redundant ARIA attributes. | ||
| summaryAdditional: This ultimately improved accessibility usage, particularly with screen readers. | ||
| isBreaking: true |
There was a problem hiding this comment.
Suggested change
| summary: Removed redundant ARIA attributes. | |
| summaryAdditional: This ultimately improved accessibility usage, particularly with screen readers. | |
| isBreaking: true | |
| summary: Removed redundant ARIA attributes to improve the screen reader experience. | |
| summaryAdditional: Update range markup to incorporate these updates. | |
| isBreaking: true | |
| affectsMarkup: true |
There was a problem hiding this comment.
Made a small change to summaryAdditional because on first read, I didn't read it as instructions
summaryAdditional: To incorporate these changes, update your range component markup.
Let me know what you think!
amyleadem
suggested changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changelog for
uswds/uswds#5413
Preview link
Range changelog →