USWDS-Site - Changelog: add entry and doc updates for sticky table headers [USWDS#5420] #2229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 9, 2023 13:43
…nto al-documentation-5420
amyleadem
commented
Aug 14, 2023
package.json
Outdated
| @@ -101,6 +101,6 @@ | |||
| "snyk": true, | |||
| "dependencies": { | |||
| "@uswds/compile": "^1.0.0-beta.3", | |||
| "@uswds/uswds": "^3.5.0" | |||
| "@uswds/uswds": "github:uswds/uswds#al-sticky-table-header" | |||
There was a problem hiding this comment.
Warning
We should revert this branch before merge
added 2 commits
August 14, 2023 09:06
- Accidentally pulled in to this PR
amyleadem
commented
Aug 14, 2023
mahoneycm
suggested changes
Aug 15, 2023
There was a problem hiding this comment.
Hey Amy! I noticed a visual bug when looking at the component preview. More detail in comments below.
I think we should also add usage guidance about not using it with the stacked or scrollable variants to the usability section. We have similar guidance on when not to use sortable tables
Let me know what you think!
added 2 commits
January 10, 2024 15:56
- This accommodates the height of the sticky header
5 tasks
added 7 commits
February 20, 2024 12:35
…cumentation-5420
…cumentation-5420
mahoneycm
reviewed
Feb 29, 2024
added 2 commits
February 29, 2024 08:13
…nto al-documentation-5420
…nto al-documentation-5420
added 2 commits
March 5, 2024 07:15
…nto al-documentation-5420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR #5420 introduced sticky table headers as a new variant for USWDS tables. This PR adds documentation for the new variant.
Important
This branch will have build failures until uswds is updated to include the changes in 3.8.0 (particularly, uswds/uswds#5420).
New variant
.usa-table--sticky-headerNew settings
$theme-table-background-colordefaultuses the body background color.$theme-table-sticky-top-offsetPreview link
Testing and review