USWDS - Footer: Fix overflow focus cutoff and padding #6237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `overflow: hidden` doesn't seem to serve any purpose, and cuts off the focus ring of elements at the edge of the footer.
amyleadem
commented
Dec 3, 2024
| @@ -66,6 +65,7 @@ $-chevron-expand-more: map-merge( | |||
|
|
|||
| .usa-footer__primary-container { | |||
| @include grid-container($theme-footer-max-width); | |||
| @include u-padding-x(0); | |||
There was a problem hiding this comment.
Note
This is the only meaningful change from #6093. All other changes are just re-ordering the style rules to match convention.
There was a problem hiding this comment.
I think this looks good to me! Both issues are fairly related, so getting both done in one pull makes sense to me
mahoneycm
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
This looks great! All three variants are much more uniform now.
Question: Should we set the target to #6093? Or are we going to close that one in favor of this one?
It might be good to keep the previous one due to the discussion and decisions captured there
This was referenced Dec 5, 2024
thisisdano
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed
overflow: hiddenfromusa-footerto allow the full focus outline to show. This fix also improves alignment in the slim footer variant.Note
This is a follow-on for PR #6093 (Thanks @6TELOIV!)
Breaking change
This is not a breaking change.
Related issue
Closes #6092
Related pull requests
Changelog
Preview link
Footer component
Problem statement
Focus rings are visually cut off in the footer. Additionally, the padding in the slim footer prevents the top border from extending the full width of the component (like it does in the other variants).
Solution
overflow: hiddenallows focus rings to show at the edge of the footer.Screenshots
Default footer
Slim footer
Note that this change also fixes the slim footer alignment in medium screen widths:
Testing and review
overflow: hidden