USWDS - Core: Replace receptor library "once" with once option for event listeners #6172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added a commit
to aduth/uswds
that referenced
this pull request
Nov 1, 2024
Review feedback from uswds#6172
mahoneycm
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
LGTM! I like that we can use this native solution here. Thanks @aduth !
- Replacement
onceis equivalent to previous value - Verify that skipnav removes
tabindexfrom body after activating and then moving focus away from the body. - Verify that in-page navigation removes
tabindexfrom the target heading after activating and then moving focus away from the heading.
amyleadem
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Looks good to me! Thanks for breaking out this work, @aduth.
I confirmed the following:
- No change in behavior with
tabindexon target headers with in-page navigation - No change in behavior with
tabindexon target element (main) with skipnav - No regressions in core functionality of in-page nav or skipnav
- No errors with prettier or linting
This was referenced Jan 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduced the JavaScript bundle size. By optimizing the implementation of core component code, overall JavaScript sizes are reduced.
Breaking change
This is not a breaking change.
Related pull requests
Split from #5793, to simplify review.
Preview link
N/A
Problem statement
See #5793
Solution
Replace use of
receptor/oncewithaddEventListener'sonceoption (see documentation).The intended purpose is the same.
receptor.once:addEventListeneronceTesting and review
Verify that skipnav removes
tabindexfrom body after activating and then moving focus away from the body.Verify that in-page navigation removes
tabindexfrom the target heading after activating and then moving focus away from the heading.