-
Notifications
You must be signed in to change notification settings - Fork 1.1k
USWDS - Time picker: Add clarity to hint text #6147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add clarity to example hint instructions
@finekatie and/or @JaymeCharles, can you review this hint text and let me know if you have any recommendations for improvement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Might be worth checking for feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Hint text seems clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tiny phrasing improvement we could make in the future might be figuring out a better word than "input," which might be jargon-y for some people. Also noting "input" wasn't in the original text proposed over here.
But this is better than what we have currently, so I'm putting this one through. @finekatie , if you could put this in your backlog to discuss at some point with a low priority since we have a more immediate fix live, that would be great. Thanks!
Thinking of adding a sub task to that issue. Make sense to you? |
Summary
Updated the time picker hint text to improve clarity. This update allows the component to meet the success criteria in WCAG 3.3.2.
Markup change
To incorporate this update, teams should replace the hint text content in the time picker from "hh:mm" to "Select a time from the dropdown. Type into the input to filter options.":
Note that this content update is not required if your project has already added instructional hint text that meets WCAG 3.3.2 criteria.
Breaking change
This is not a breaking change.
Related issue
Closes #6061
Related pull requests
Changelog PR
Note
The related test on the accessibility test page should be marked as conditional after this change is implemented.
Preview link
Time picker component
Problem statement
The existing visible instructions for time picker aren't sufficient to prevent errors; we need to add clarity to the format and options to prevent users from typing in potentially invalid times.
See https://www.w3.org/TR/WCAG20/#minimize-error-cues for clarification on 3.3.2
Solution
This PR updates the hint text to give instructions for how to interact with the component.
Testing and review