Skip to content

USWDS - Input: Add error state story #5996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2024
Merged

USWDS - Input: Add error state story #5996

merged 2 commits into from
Oct 3, 2024

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Jul 26, 2024 •
edited
Loading

Summary

Created error state Storybook controls and preview to showcase error styles.

Breaking change

This is not a breaking change

Related issue

Closes #5991

Related pull requests

No changelog created. Not a user-facing change.

Preview link

Text input error story →

Problem statement

We need stories to showcase error states on the design system website.

Solution

Create an error state storybook preview for text input to match existing controls.

Major changes

  • New option for state control for text input component
  • New error state input story
  • Conditional logic wraps each text input and it's relevant labels in usa-form-group usa-form-group--error divs.

Testing and review

  1. Visit text input story
  2. Confirm controls work as expected
  3. Confirm the error input has expected markup
  4. Confirm error state is displaying correctly
  5. Confirm there are no regressions in other states
  6. Confirm pattern matches existing variants / components

@mahoneycm mahoneycm marked this pull request as ready for review July 26, 2024 19:55
@mahoneycm mahoneycm requested review from mejiaj and amyleadem July 26, 2024 19:55
amyleadem
amyleadem suggested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this prepped so quickly, @mahoneycm. I had a few small notes in the comments below. Let me know if you have any questions.

@mahoneycm mahoneycm requested a review from amyleadem August 6, 2024 21:10
amyleadem
amyleadem approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @mahoneycm

mejiaj
mejiaj approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can see all form error states.

@mejiaj mejiaj requested a review from thisisdano August 28, 2024 14:30
@amyleadem amyleadem mentioned this pull request Sep 30, 2024
Merged
3 tasks
@thisisdano thisisdano merged commit e65bc75 into develop Oct 3, 2024
5 checks passed
@thisisdano thisisdano deleted the cm-input-error-story branch October 3, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@mejiaj mejiaj mejiaj approved these changes

@thisisdano thisisdano thisisdano approved these changes

@amyleadem amyleadem amyleadem approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USWDS - Feature: Create Input error state Storybook preview
4 participants
@mahoneycm @mejiaj @thisisdano @amyleadem