USWDS - Validation: Remove ability to focus checklist items #5835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2024
amyleadem
approved these changes
Apr 4, 2024
|
@amyleadem Sounds good to me! Updated issue milestone to |
mejiaj
approved these changes
May 2, 2024
thisisdano
approved these changes
May 22, 2024
Merged
patrickcate
added a commit
to patrickcate/vue-uswds
that referenced
this pull request
Jul 5, 2024
This aligns with the USWDS 3.8.1 change: uswds/uswds#5835
patrickcate
added a commit
to patrickcate/vue-uswds
that referenced
this pull request
Jul 5, 2024
This aligns with the USWDS 3.8.1 change: uswds/uswds#5835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug which caused non-interactive checklist items to receive focus on tab. Now, only the interactive input will receive focus.
Created #5841 as a follow up to enhance screen reader callouts for the validation input element.
Breaking change
This is not a breaking change.
Related issue
Closes #5760
Related pull requests
Changelog →
Preview link
Validation component →
Problem statement
tabindex="0"was added to checklist items in #4914 to make the validation checklist items easier to navigate via tab.This could prove confusing to keyboard users because text typically isn’t focusable in the DOM unless it’s interactive. 1
Solution
Remove
tabindexfrom checklist items.Testing and review
Testing checklist
tabindexFootnotes
Comment from Amy C. ↩