Skip to content

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Mar 1, 2024

Summary

Fixes a build failure currently on develop branch affecting all pull requests, described at #5233 (comment) .

Related pull requests

#5233

Testing and review

Build should pass.

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix!

I performed the following tests:

  • Confirm the error is present on develop after running npm run test:a11y
  • Confirm there are no errors on this branch after running npm run test:ci
  • Confirm the “Textarea validation” story still behaves as expected

Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick fix 👍

@mahoneycm mahoneycm requested a review from thisisdano March 1, 2024 15:51
Copy link
Contributor

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thisisdano thisisdano merged commit 4ec68ce into uswds:develop Mar 1, 2024
@aduth aduth deleted the aduth-textarea-build-failure branch March 1, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants