USWDS - Site Alert - Repair top margin, broken by #4922 #5550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR uswds#4922 added a top margin to the site alert, which looks wrong when a site alert immediately follows a gov banner.
|
Great patch. We're going to work to get this into 3.7.0. |
amyleadem
approved these changes
Oct 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed the top margin from the site alert component.
PR #4922 added a top margin to the site alert, which looks wrong when a site alert immediately follows a gov banner.
Breaking change
This is not a breaking change.
Related PR
Changelog PR
Preview link
This affects https://test.gcn.nasa.gov.
USWDS 3.1.0
USWDS 3.6.1, before this patch
After this patch
Problem statement
The site alert should not have any top margin. It didn't before USWDS 3.6.1. The margin looks like a glitch when a site alert immediately follows a gov banner.
Solution
Move the top margin back from the mixin to _usa-alert.scss so that applies to alerts but not site alerts.
Testing and review
I tested this locally to produce the screenshots above.
Dependency updates
None.