Input mask: validate on paste cleanup #5271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
May 3, 2023 14:02
Adjustments for readability.
- Allow randomID to be passed (useful in unit tests) - Separate ID generation from string for readability
This function returned the input element, which made it redundant. It _used_ to return the component container, but that was removed in 9a49a4e. .
- Remove redundant vars in favor of default param pastedText - Remove loop in favor of removeFormatCharacters() - Pass cursor position to getValidPastedText() - Create new const to track starting point from cursor position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the following functionality:
Strip invalid characters from paste, but keep valid.This is still WIP ― submitting for now to share core functional changes.Related pull requests
Related to #5227.
Preview link
Preview link:
Input mask
Problem statement
Pasting a mix of valid/invalid characters returns an empty string, instead of the valid characters.Solution
line 1051-1058]getPastedText() → getValidPastedText()for clarity and accuracy. [50808ab]createStatusMessages()to accept a user set randomID ― helpful in unit testing.getMaskedElements()because it wasn't returning anything useful. The passedinputElwas being returned as a newly namedmaskedEl.usa-input-maskwrapper that contained everything. A function like this might return as we continue to develop. [35aff85]forloops in favor ofremoveFormatCharacters()[42e9fcb].Major changes
handlepaste().getPastedText()togetValidPastedText().