USWDS input mask version 2 #5104
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James Mejia <james.mejia@gsa.gov>
Co-authored-by: James Mejia <james.mejia@gsa.gov>
- Use code for pipe character - Add empty alt text for pseudoelement to prevent character being read on screenreaders Based on guidance https://www.w3.org/TR/css-content-3/#alt
USWDS documentation on header says there is a theme setting to adjust the logo text width. It does not work with header-extended. This fixes that. https://designsystem.digital.gov/documentation/settings/ Verify where else this variable is used and if the default value needs to be updated. Documentation says default values 33%, header-extended uses default value 50%
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…ils-1.4.1 Bump loader-utils from 1.4.0 to 1.4.1
Output woff and ttf font-face references only with explicit compatibility setting
USWDS 3.4.0
Sync develop 3.4.0
- Describe what makes a breaking change - Add section for related PRs - Remove checkbox item related to Changelog
- Fixed spacing - Added link to uswds-site - Add missing word Co-authored-by: Amy Leadem <93996430+amyleadem@users.noreply.github.com> Co-authored-by: mahoneycm <charlie.mahoney@bixal.com>
|
@thisisdano hastily merged |
22 tasks
|
Closing this PR in favor of #5227 |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty large rewrite of the input mask component with a ton of improvements. I tried to keep the requirements to implement as close to version 1 as possible, however, there are some additional requirements that a developer must implement if they upgrade to this version.
The most important update required is the addition of a
.usa-input-maskwrapper and the class.usa-input-mask__fieldadded to the input element. This allowed for some great feedback if a user types an incorrect character. This also follows the character count architecture FYI.Here is updated input mask implementation guidance featuring previews with working masks:
https://federalist-ead78f8d-8948-417c-a957-c21ec5617a57.sites.pages.cloud.gov/preview/uswds/uswds-site/mm-input-mask-guidance/components/input-mask/
Here is the component page:
https://federalist-3b6ba08e-0df4-44c9-ac73-6fc193b0e19c.sites.pages.cloud.gov/preview/uswds/uswds/mm-input-mask/?path=/story/components-form-inputs-text-input-mask--ssn
UPDATE: Here is the uswds-site PR for the guidance udpates:
uswds/uswds-site#1995
Looking forward to feedback!