Skip to content

Sync develop 3.4.0 #5174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Mar 9, 2023
Merged

Sync develop 3.4.0 #5174

merged 31 commits into from
Mar 9, 2023

Conversation

thisisdano
Copy link
Contributor

@thisisdano thisisdano commented Mar 9, 2023 •
edited
Loading

Update develop with the latest from main (USWDS 3.4.0).

thisisdano and others added 30 commits January 24, 2023 10:57
@thisisdano
Add basic proof of concept
12aaf94
@thisisdano
Support "filetypes" key in custom font src
50c93b2
@thisisdano
Fix typo
ce8db0a
@thisisdano
Move filetypes into variables
c31482d
@thisisdano
Use project filetypes in functions
690a6dd
@thisisdano
Move filetype defaults into variables
f196516
@thisisdano
Be clear about location of settings error
c32ca0c
@thisisdano
Add compileSass task for troubleshooting
8b6541a
@thisisdano
Update mocha to resolve critical vuln
5b77854
@thisisdano
npm audit fix
a50a360
@thisisdano
Swap gulp-spawn-mocha with gulp-mocha to resolve critical vuln
cbac3a1
@thisisdano
Remove unused package and update sass-embedded
77feb37
@thisisdano
Merge branch 'release-3.4.0' into dw-update-fontface
f8a6cb3
@thisisdano
Move function to functions
95cc575
@thisisdano
Use consistent mixin naming
7c77796
@thisisdano
Use shorthand in map.has-key
408537f
@thisisdano
Use Sass function style (hyphens)
569717f
@thisisdano
Simplify key and code...
9fa9027 
Since the compatibility choice is binary (support older browsers or only modern browsers), we don't need granularity in our font key. We only need "output all formats" or "output only modern formats". This simplifies the code to have a simple `true`/`false` for a `compatibility` key
@thisisdano
Update function docs
77139cd
@thisisdano
Use false as compatibility default
8e111ca
@thisisdano
Use a setting instead of a custom source key
20f85eb
@thisisdano
Remove unused filetypes variables
59514c6
@thisisdano
Uodate function docs
7bea869
@thisisdano
Merge pull request #5108 from uswds/dw-update-fontface
e4423b1 
Output woff and ttf font-face references only with explicit compatibility setting
@thisisdano
Update _settings-typography.scss
06e61fb
@thisisdano
Add font format note to notifications
f01358f
@thisisdano
3.4.0
18550e6
@thisisdano
Create uswds-3.4.0-zip-hash.txt
405866f
@thisisdano
Update references to 3.4.0
ddbff51
@thisisdano
Update uswds-3.4.0-zip-hash.txt
48b0cd6
@thisisdano thisisdano requested a review from mejiaj March 9, 2023 23:13
@thisisdano thisisdano marked this pull request as ready for review March 9, 2023 23:19
@thisisdano thisisdano merged commit 5d79d7a into develop Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mejiaj mejiaj mejiaj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisisdano @mejiaj