USWDS 3.4.0 #5170
Merged
USWDS 3.4.0 #5170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: James Mejia <james.mejia@gsa.gov>
Co-authored-by: James Mejia <james.mejia@gsa.gov>
- Use code for pipe character - Add empty alt text for pseudoelement to prevent character being read on screenreaders Based on guidance https://www.w3.org/TR/css-content-3/#alt
Sync develop 3.3.0
USWDS: Modal with nested forms. Resolves #4953
Since the compatibility choice is binary (support older browsers or only modern browsers), we don't need granularity in our font key. We only need "output all formats" or "output only modern formats". This simplifies the code to have a simple `true`/`false` for a `compatibility` key
Output woff and ttf font-face references only with explicit compatibility setting
mejiaj
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Looks good! I've tested:
- Ran
npm auditand verified security info - Ran
npm testwithout issues - Compiled SASS (
npx gulp compileSass) successfully - Built templates (
npm run build:html) successfully - Reviewed release notes for spelling errors
- Looked for old USWDS references
|
Ugh, I did find an old |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s new in USWDS 3.4.0
Features and bug fixes
usa-bannerusa-layout-gridpackage withusa-bannerresulting in a much smaller package size. (#5000)uswds-corewoff2webfont format with our default settings. Since we no longer support IE11 and other old browsers, we no longer need to serve thewoffandttfformats. Teams that need this support can activate it with a new setting:$theme-font-browser-compatibility: true. This is only a breaking change if your project needs to support IE11. (#5108)usa-header"none"for anymax-widthsetting, including$theme-header-max-width.(#5072)usa-in-page-navigationusa-alertuswds-core1.5for$theme-alert-padding-y. Thanks @aduth! (#5076)usa-bannerusa-footer.usa-footer__primary-linkwithout it reverting to anh4when the JavaScript rebuilds the element for mobile. Thanks @paulathevalley! (#5044)usa-headerusa-linkusa-modalusa-step-indicatoruswds-utilitiesuswds-core05token. Now, the.outline-05utility class and theu-outline('05')mixin should work as expected. (#5079)Dependencies and security
gulp-dart-scssgulp-mochamochasass-embeddedsnyk0vulnerabilities in regular dependencies (dependencies for USWDS projects installed withnpm install uswds)1 moderate 33 highvulnerabilities in devDependencies (development dependencies)Release TGZ SHA-256 hash:
7b0336d95fa6e9f31b27a27424f3a53e84b415e09b5bbff5d9ec8a398fb406d7