Skip to content

USWDS: Banner - Remove grid-layout dependency. Resolves #4868 #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 28, 2023
Merged

USWDS: Banner - Remove grid-layout dependency. Resolves #4868 #5000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f7d1e92
Remove grid dependency and set display: flex
mahoneycm Oct 18, 2022
e2696c0
Merge branch 'develop' of github.com:uswds/uswds into cm-usa-banner-p…
mahoneycm Nov 17, 2022
23ecc99
Replace max width and auto margins that were removed with grid-container
mahoneycm Nov 17, 2022
34542ea
Update banner classes to work without grid-row
mahoneycm Dec 1, 2022
4ad8653
Fix expanded mobile views
mahoneycm Dec 6, 2022
7cd9369
Prevent content shift when expanded on small screens
mahoneycm Dec 6, 2022
31918ed
Fix flex grow on desktop view
mahoneycm Dec 6, 2022
7c9db37
Replace flex styles with grid mixins
mahoneycm Dec 28, 2022
3184857
Replace missing bracket
mahoneycm Dec 28, 2022
8663017
Replace grid mixins
mahoneycm Dec 29, 2022
f1f7f7d
Move grid-row styles
mahoneycm Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/usa-banner/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
//dependencies
@forward "uswds-fonts";
@forward "usa-layout-grid";
@forward "usa-media-block";

// src
Expand Down
14 changes: 14 additions & 0 deletions packages/usa-banner/src/styles/_usa-banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,20 @@ $banner-icon-close: (
.usa-accordion {
@include typeset($theme-banner-font-family);
}

.grid-row {
@include grid-row;

&.grid-gap-lg {
@include grid-gap("lg");
}

.tablet\:grid-col-6 {
@include at-media("tablet"){
@include grid-col(6);
}
}
}
}

.usa-banner__header,
Expand Down