USWDS - Step indicator: Fix color contrast on pending items #5048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahoneycm
approved these changes
Nov 28, 2022
mejiaj
approved these changes
Nov 29, 2022
|
Removing from milestone because it's issue #4836 is already linked. |
…-indicator-contrast
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the default value for
$theme-step-indicator-segment-color-pendingfrombase-lightertogray-40. Now, the graphical elements related to pending items meet accessibility standards for contrast ratio.Related issue
Closes #4836
Preview link
Preview link: Step indicator page
Problem statement
Meaningful graphical objects must have a color contrast ratio of at least 3:1. However, the pending items in the step indicator have a contrast ratio of only 1.25.
Solution
Updating the default value of
$theme-step-indicator-segment-color-pendingfrombase-lighter(#e6e6e6) togray-40(#919191) creates a color contrast of 3.15, which passes standards for graphical objects.Before opening this PR, make sure you’ve done whichever of these applies to you:
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch isdevelop).npm testand confirm that all tests pass.