USWDS - 404 error template: Update sentence structure #5045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bonnieAcameron
approved these changes
Dec 2, 2022
|
Converting to draft so that we can incorporate the Spanish language edits. |
|
@mejiaj I updated the Spanish template to include the recommended copy. Can you confirm that it reads as expected? |
mejiaj
approved these changes
Dec 20, 2022
|
Removing from |
thisisdano
approved these changes
Feb 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated template copy in the 404 templates to follow parallel structure and use active voice.
This PR pulls in the copy update established in uswds/uswds-site#1802 (English) and #5060 (Spanish). This PR is an extension of original issue #4225.
Thanks to @ybom for the Spanish translation!
Breaking
This is not a breaking change, but sites that use the 404 template copy should update.
Related issue
Closes: #4980
Preview link
Next steps
Evaluate if the Spanish version of the template needs similar updatesDONEuswds-site.Before opening this PR, make sure you’ve done whichever of these applies to you:
git pull origin [base branch]to pull in the most recent updates from your base and check for merge conflicts. (Often, the base branch isdevelop).npm testand confirm that all tests pass.