-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
Affects: Accessibility 🟡Relates to the accessibility of our componentsRelates to the accessibility of our components
Milestone
Description
Describe the bug
Testing validator updates in #4719 results in the following a11y errors:
Errors in http://localhost:4000/components/validation/:
• Elements must only use allowed ARIA attributes
(https://dequeuniversity.com/rules/axe/3.5/aria-allowed-attr?application=axeAPI)
(#validate-code > li:nth-child(1))
<li class="usa-checklist__item" data-validator="uppercase"
aria-checked="false"> Use at least one u...</li>
• Elements must only use allowed ARIA attributes
(https://dequeuniversity.com/rules/axe/3.5/aria-allowed-attr?application=axeAPI)
(#validate-code > li:nth-child(2))
<li class="usa-checklist__item" data-validator="numerical"
aria-checked="false"> Use at least one n...</li>
Steps to reproduce the bug
- Use branch for USWDS - Validation: Adds complete/incomplete labels for screen readers. Resolves #4477 #4719
- Build site
- Create federalist preview with draft PR
- View failed CircleCI tests
- Click
details
link - See errors
Expected Behavior
A11Y tests should pass
Related code
Work was done in USWDS PR #4719.
Screenshots
No response
System setup
- USWDS v3.1.0
Additional context
We should look into adding the necessary role
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-checked#associated_roles
Or change the markup so it the validation state is accurate without aria-checked
After adding aria-role="checkbox"
Code of Conduct
- I agree to follow this project's Code of Conduct.
- I checked the current issues for duplicate bug reports.
Metadata
Metadata
Assignees
Labels
Affects: Accessibility 🟡Relates to the accessibility of our componentsRelates to the accessibility of our components
Type
Projects
Status
Done