Feature: support windows-curses for curses under windows #692
+107
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `curses` optional dependencies group * Default windows-curses require UTF-8 encoding to work Due to issue urwid#690 not adding windows instructions to the manual ---------------------------------------------------------------
penguinolog
commented
Dec 8, 2023
| @@ -429,6 +432,10 @@ def read_cursor_position(self, keys, more_available: bool): | |||
| 360: "end", | |||
| } | |||
|
|
|||
| if IS_WINDOWS: | |||
| _keyconv[351] = "shift tab" | |||
| _keyconv[358] = "end" | |||
penguinolog
commented
Dec 8, 2023
| @unittest.skipIf(IS_WINDOWS, "Windows is temporary not supported by TornadoEventLoop.") | ||
| @unittest.skipIf( | ||
| IS_WINDOWS, | ||
| "Windows is temporary not supported by TornadoEventLoop due to race conditions.", |
There was a problem hiding this comment.
stable enough, maybe reason to enable some atomic tests before issue will be fully fixed
Pull Request Test Coverage Report for Build 7144233062
💛 - Coveralls |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cursesoptional dependencies groupDue to issue #690 not adding windows instructions to the manual
Fix #447
Successfully tested under windows 11 with enforced UTF-8 encoding:
Checklist
masterorpython-dual-supportbranchtoxsuccessfully in local environment