use Self from typing_extensions #3364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illia-v
previously approved these changes
Mar 17, 2024
There was a problem hiding this comment.
Thanks @asottile!
New usage of Self coincides with https://typing.readthedocs.io/en/latest/spec/generics.html#valid-locations-for-self, one little nit is about the tense in the news entry.
illia-v
approved these changes
Mar 17, 2024
wimglenn
reviewed
Apr 23, 2024
| @@ -462,7 +462,7 @@ def __ior__(self, other: object) -> HTTPHeaderDict: | |||
| self.extend(maybe_constructable) | |||
| return self | |||
|
|
|||
| def __or__(self, other: object) -> HTTPHeaderDict: | |||
| def __or__(self, other: object) -> Self: | |||
There was a problem hiding this comment.
@asottile Why not also on __ior__ above?
There was a problem hiding this comment.
I seem to remember it generated an error on a subclass so I skipped it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3363