Allow passing negative integers as amt to read methods
#3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, Windows 3.13 tests started to fail because of python/cpython#115582 |
sethmlarson
requested changes
Feb 28, 2024
test/test_response.py
Outdated
| @@ -1272,7 +1285,7 @@ def test_mock_transfer_encoding_chunked_unlmtd_read(self) -> None: | |||
| resp = HTTPResponse( | |||
| r, preload_content=False, headers={"transfer-encoding": "chunked"} | |||
| ) | |||
| assert stream == list(resp.read_chunked()) | |||
| assert stream == list(resp.read_chunked(amt)) | |||
There was a problem hiding this comment.
We're losing a testcase here, can we test not passing a parameter using *read_chunked_args with [(), (None,), and (-1,)] as our parametrized cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3122.
According to https://docs.python.org/3/library/io.html#io.BufferedIOBase.read, if the [size] argument is omitted,
None, or negative, data is read and returned until EOF is reached.urllib3 (as well as httplib) breaks when a negative number is passed to its read methods. This PR fixes the issue by making urllib3 treat negative numbers the same as
None.