Add nox configuration to start pyodine console #3338

ecerulm · 2024-02-01T21:58:35Z

This adds a nox session called pyodineconsole.

nox -rs pyodineconsole
nox > Running session pyodineconsole
nox > Re-using existing virtual environment at .nox/pyodineconsole.
nox > python -m pip install build
nox > python -m build
* Creating venv isolated environment...
* Installing packages in isolated environment... (hatchling>=1.6.0,<2)
* Getting build dependencies for sdist...
* Building sdist...
* Building wheel from sdist
* Creating venv isolated environment...
* Installing packages in isolated environment... (hatchling>=1.6.0,<2)
* Getting build dependencies for wheel...
* Building wheel...
Successfully built urllib3-2.2.0.tar.gz and urllib3-2.2.0-py3-none-any.whl
nox > cp templates/pyodide-console.html dist/index.html
nox > cd dist
nox > python -m http.server
Serving HTTP on :: port 8000 (http://[::]:8000/) ...

This nox session

builds the wheel for urllib into dist/
creates a index.html file in dist/, with a pyodine terminal taken
from pyodine src/templates/console.html
autoruns a series of commands on this terminal
- import micropip
- await micropip.install("http://localhost:8000/urllib3-2.2.0-py3-none-any.whl")
- import urllib3
- urllib3.__version__

Then you open http://localhost:8000 and you will be presented with

Closes #3330

ecerulm · 2024-02-01T22:07:48Z

@sethmlarson , please try this pyodide console approach and tell me if that's what you were looking for when you wrote #3330

sethmlarson

Thanks for opening this! I put some early comments below:

sethmlarson · 2024-02-01T22:30:19Z

noxfile.py

@@ -200,6 +200,18 @@ def lint(session: nox.Session) -> None:
    mypy(session)


+@nox.session(python="3.11")
+def pyodineconsole(session: nox.Session) -> None:


typo: pyodide*

sethmlarson · 2024-02-05T14:30:55Z

noxfile.py

@@ -200,6 +200,18 @@ def lint(session: nox.Session) -> None:
    mypy(session)


+@nox.session(python="3.11")


Does this need to be a specific Python version, or can we use any 3.x?

If we don't specify a version then nox will run the same python interpreter used to run nox itself.

I mean, the alternative skip nox (which is for test automation, not for this).

I can create a python script to create virtualenv , install dependencies, etc instead. then we are not bound by the nox rules.

noxfile.py

sethmlarson · 2024-02-05T14:31:58Z

templates/pyodide-console.html

@@ -0,0 +1,267 @@
+<!doctype html>


Can we find a new home for this file? Maybe under test/ for Emscripten?

Did you write this file yourself or is it from somewhere, I don't see license information.

What is the expected maintenance requirements for this file?

Can we find a new home for this file? Maybe under test/ for Emscripten?

Sure, I can do that.

Did you write this file yourself or is it from somewhere, I don't see license information.

I mentioned in the PR description

creates a index.html file in dist/, with a pyodine terminal taken
from pyodide src/templates/console.html

The LICENSE is https://github.com/pyodide/pyodide/blob/main/LICENSE. (Mozilla Public License Version 2.0)

I can add a comment on the top of the file with the original source url, not sure , should I add a "copyright" comment although the original does not have it? The closest copyright notice that I can find in their repo is "2019-2022, Pyodide contributors and Mozilla", I can add that?

What is the expected maintenance requirements for this file?

I guess we won't maintain this file. It's the same jQuery REPL that is used in https://pyodide.org/en/stable/console.html, if it stops working we can always copy the latest from pyodide src/templates/console.html. And then add the lines

await term.ready; await term.exec("import micropip\n"); await term.exec("micropip.list()\n"); await term.exec('await micropip.install("http://localhost:8000/urllib3-2.2.0-py3-none-any.whl")') await term.exec("micropip.list()"); await term.exec("import urllib3"); await term.exec("urllib3.__version__");

Thank you, apologies for not reading the description closely enough

ecerulm · 2024-02-05T15:11:15Z

templates/pyodide-console.html

+        await term.ready;
+        await term.exec("import micropip\n");
+        await term.exec("micropip.list()\n");
+        await term.exec('await micropip.install("http://localhost:8000/urllib3-2.2.0-py3-none-any.whl")')
+        await term.exec("micropip.list()");
+        await term.exec("import urllib3");
+        await term.exec("urllib3.__version__");


@sethmlarson , this is the part that I added to the original https://github.com/pyodide/pyodide/blob/3500c17468e474902044413679b024dc7af75621/src/templates/console.html

ecerulm · 2024-02-05T15:40:05Z

test/contrib/emscripten/templates/pyodide-console.html

+<!-- taken from https://github.com/pyodide/pyodide/blob/main/src/templates/console.html -->
+<!-- Copyright (C) 2019-2022, Pyodide contributors and Mozilla -->
+<!-- SPDX-FileCopyrightText: 2019-2022, Pyodide contributors and Mozilla -->
+<!-- SPDX-License-Identifier: MPL-2.0 -->


@sethmlarson , I added mention of the source, copyright and license here.

sethmlarson

This is awesome and perfectly recreates the issue w/ InsecureRequestWarning, thank you @ecerulm!

sethmlarson · 2024-02-05T16:04:31Z

@ecerulm The linked issue was a bounty issue for $100, so if you're able to please submit an expense to our Open Collective linking back to this PR.

ecerulm force-pushed the pyodine_console branch from cf8c98c to dfbea5b Compare February 1, 2024 22:01

Add nox session for pyodine console

8adac23

ecerulm force-pushed the pyodine_console branch from dfbea5b to 8adac23 Compare February 1, 2024 22:06

ecerulm added the Skip Changelog Pull requests that don't require a changelog entry label Feb 1, 2024

ecerulm force-pushed the pyodine_console branch from 7c00780 to 8adac23 Compare February 2, 2024 10:28

ecerulm marked this pull request as ready for review February 5, 2024 10:04

ecerulm requested a review from pquentin February 5, 2024 10:04

sethmlarson reviewed Feb 5, 2024

View reviewed changes

ecerulm commented Feb 5, 2024

View reviewed changes

ecerulm added 2 commits February 5, 2024 16:14

Merge remote-tracking branch 'origin/main' into pyodine_console

073bedd

Add license and copyright to the pyodide REPL

cc06c84

ecerulm commented Feb 5, 2024

View reviewed changes

sethmlarson approved these changes Feb 5, 2024

View reviewed changes

sethmlarson merged commit 9929d3c into urllib3:main Feb 5, 2024

ecerulm deleted the pyodine_console branch February 5, 2024 17:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add nox configuration to start pyodine console #3338

Add nox configuration to start pyodine console #3338

Uh oh!

ecerulm commented Feb 1, 2024 •

edited

Loading

Uh oh!

ecerulm commented Feb 1, 2024

Uh oh!

sethmlarson left a comment

Uh oh!

sethmlarson Feb 1, 2024

Uh oh!

sethmlarson Feb 5, 2024

Uh oh!

ecerulm Feb 5, 2024

Uh oh!

Uh oh!

sethmlarson Feb 5, 2024

Uh oh!

ecerulm Feb 5, 2024

Uh oh!

sethmlarson Feb 5, 2024

Uh oh!

ecerulm Feb 5, 2024

Uh oh!

ecerulm Feb 5, 2024

Uh oh!

sethmlarson left a comment

Uh oh!

sethmlarson commented Feb 5, 2024

Uh oh!

Uh oh!

		@@ -200,6 +200,18 @@ def lint(session: nox.Session) -> None:
		mypy(session)


		@nox.session(python="3.11")

Uh oh!

Add nox configuration to start pyodine console #3338

Add nox configuration to start pyodine console #3338

Uh oh!

Conversation

ecerulm commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ecerulm commented Feb 1, 2024

Uh oh!

sethmlarson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sethmlarson left a comment

Choose a reason for hiding this comment

Uh oh!

sethmlarson commented Feb 5, 2024

Uh oh!

Uh oh!

ecerulm commented Feb 1, 2024 •

edited

Loading