Skip to content

ensure HTTPSconnection.is_verified is set properly #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Jan 17, 2024
Merged

ensure HTTPSconnection.is_verified is set properly #3283

merged 2 commits into from Jan 17, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2024

Followup Issue

Relevant code needs to be revised & (self)documented (to avoid such kind of bugs in future)

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit bbba487 into urllib3:main Jan 17, 2024
Ousret added a commit to jawah/urllib3.future that referenced this pull request Dec 22, 2024
2.12.904 (2024-12-22)
=====================

- Fixed an issue when trying to force load Websocket over HTTP/2 or
HTTP/3.
- Ensured WebSocket via HTTP/2 with improved CI pipeline featuring
haproxy as the reverse proxy.
- Fixed ``RuntimeError`` when forcing HTTP/3 by disabling both HTTP/1,
and HTTP/2 and the remote is unable to negotiate HTTP/3.
This issue occurred because of our automatic downgrade procedure
introduced in our 2.10.x series. The downgrade ends in panic
due to unavailable lower protocols. This only improve the UX by not
downgrading and letting the original error out.
See jawah/niquests#189 for original user
report.
- Fixed negotiated extensions for WebSocket being ignored (e.g.
per-deflate message).
- Backported ``HTTPResponse.shutdown()`` and nullified it. The fix they
attempt to ship only concern
them, we are already safe (based on issue reproduction). See
urllib3#2868
- Backported ``proxy_is_tunneling`` property to ``HTTPConnection`` and
``HTTPSConnection``.
  See urllib3#3459
- Backported ``HTTPSConnection.is_verified`` to False when using a
forwarding proxy.
  See urllib3#3283
- Backported pickling support to ``NewConnectionError`` and
``NameResolutionError``.
  See urllib3#3480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

https_proxy to http_host leads to is_verfied==True
2 participants