Fix tests by handling ssl "record layer failure" #3271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add wait until server is ready Fix test_ssl_failure_midway_through_conn when OpenSSL 3.2.0 map "record layer failure" to "Your proxy appears..."
sethmlarson
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
LGTM, thanks for this! I tweaked the changelog entry a bit to use "our users" as an audience.
I also added a $100 bounty to this issue, so if you are able to you can submit an expense to our Open Collective. Let me know if you need help with that or questions :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3268
Assumes the the ssl error SSL_R_RECORD_LAYER_FAILURE "record layer failure" is equivalent to the "Your proxy appears to only use HTTP and not HTTPS" error.