Set proper proxy_is_verified value after connecting to proxy
#3266
Conversation
There was a problem hiding this comment.
When I set the bounty to #3130, I estimated the amount for fixing both is_verified and proxy_is_verified bugs (i.e., making the #3149 (review) tests work.) You're right though that #3130 describes only the proxy_is_verified problem, so fixing it has to be enough to close the issue.
I can see that you did try to approach this in a way to have both is_verified and proxy_is_verified fixed as the result e54f972. Could you please estimate how difficult is getting the right is_verified value for the "HTTPS proxy + HTTP destination" case?
- use assert helper function - add further tests to simplify assertions Tests still test for the initially (by illia-v) suggested values within #3149 (review) - add missing proxy_is_verified assignment this fixes test_is_verified_https_proxy_to_http_target from #3149 (by tushar5526) - add missing proxy_is_verified assignment fixes test_is_verified_http_proxy_to_http_target - fix test_is_verified_https_proxy_to_https_target assert - add missing proxy_is_verified assignment fixes test_is_verified_http_proxy_to_https_target - add changelog and TODOs, lint
There was a problem hiding this comment.
This is looking better! I had a few minor comments and then I'll let @illia-v review and decide when to merge.
proxy_is_verified value after connecting to proxy
additionally changed naming: 'host' to 'target'
|
@abebeos thank you for working on this! |
…b3#3266) Co-authored-by: Tushar <30565750+tushar5526@users.noreply.github.com> Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
closes #3130
(squashed the ~15 commits down to 1, should be still easily reviewable)