Migrate emscripten test server to Hypercorn #3230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(you just need to pull that last commit across to your branch) |
It should be able to share more code with hypercorn_app
Thank you! I'd appreciate learning how to fish, but thanks a lot for the fish! Various streaming tests don't pass at all on my Fedora 39 laptop, even on the main branch and I have no idea why. |
14 tasks
sethmlarson
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this should be relatively straightforward, various tests don't work, including some that just hang, and I have no idea how to debug this. I made some progress by looking at the server logs and noticed a few 404 errors, but everything looks good from the server point of view now. And the client errors are cryptic like "No module named js" (and that's after I changed two raise statements to stop throwing away exceptions).
@joemarshall Would you mind taking a look? This is the last test using Tornado, which I am in the process in removing, in order to have a test server that supports HTTP/2.