Migrate TestHTTPS to Hypercorn #3217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
sethmlarson
previously approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I'm planning to clean up the Tornado tests after finishing the migration, instead of removing the exact bits that are unused, which would take time.
I'm using a fork of Hypercorn here. I'm planning to merge everything back upstream as soon as possible, but doing so requires implementing the full ASGI specification, which is more work.
This migration uncovered two bugs in the test suite that was not considering that asking for "TLS 1.2 or above" could result in "TLS 1.3". Apparently this is something that Tornado was doing wrong?