Migrate TestConnectionPool to Hypercorn #3205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It relies on sending requests that violate the HTTP spec, and that are refused by h11 as used by Hypercorn, our new test server. Thankfully, we don't need the return of the server, looking at what urllib3 would have sent is enough.
pquentin
commented
Nov 21, 2023
| @@ -890,7 +896,7 @@ def test_preserves_path_dot_segments(self) -> None: | |||
| """ConnectionPool preserves dot segments in the URI""" | |||
| with HTTPConnectionPool(self.host, self.port) as pool: | |||
| response = pool.request("GET", "/echo_uri/seg0/../seg2") | |||
| assert response.data == b"/echo_uri/seg0/../seg2" | |||
| assert response.data == b"/echo_uri/seg0/../seg2?" | |||
There was a problem hiding this comment.
This is the same issue than in #3193 where Flask/Quart insists on adding a question mark.
| @@ -1061,6 +1019,8 @@ def test_headers_not_modified_by_request( | |||
| else: | |||
| conn = pool._get_conn() | |||
| conn.request("GET", "/headers", chunked=chunked) | |||
| conn.getresponse().close() | |||
| conn.close() | |||
There was a problem hiding this comment.
I was getting ResourceWarnings without closing those properly. Possibly an advantage of using Trio.
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3202, relates #3196