Skip to content

Conversation

pquentin
Copy link
Member

No description provided.

@pquentin pquentin added the Skip Changelog Pull requests that don't require a changelog entry label Nov 17, 2023
@@ -73,7 +73,7 @@
# 3. To test our timeout logic by using two different values, eg. by using different
# values at the pool level and at the request level.
SHORT_TIMEOUT = 0.001
LONG_TIMEOUT = 0.01
LONG_TIMEOUT = 0.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latency using Hypercorn+Quart is more variable than I would like, and I've seen a few read timeout errors before bumping the timeout here.

Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@sethmlarson sethmlarson merged commit 3351be5 into urllib3:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants