Skip to content

bug: artifact path issues #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

GrantBirki
Copy link
Contributor

@GrantBirki GrantBirki commented Aug 5, 2025

Summary

Fix artifact extraction path when downloading a single artifact by artifact-ids.
Previously, the artifact was extracted to a subdirectory (e.g., dist/dist). This PR sets merge-multiple: true so the artifact is extracted directly to the target folder, matching the behavior when downloading by name.

Details

  • When using artifact-ids with a single artifact, the default behavior created a nested folder (e.g., dist/dist).
  • Setting merge-multiple: true ensures the artifact contents are placed directly in the specified directory (e.g., dist/), keeping behavior consistent with single artifact downloads by name.

This change prevents unwanted extra directory nesting and makes the download experience the same whether using name or artifact-ids for a single artifact.


related: #3648

@illia-v illia-v merged commit b85700e into urllib3:main Aug 5, 2025
36 of 37 checks passed
@GrantBirki
Copy link
Contributor Author

Awesome! I see that the latest Publish to PyPI workflow succeed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants