Raise exception for shutdown on a connection already released to the pool #3601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sethmlarson Could you please review this? Thank you! |
D-stefaang
reviewed
May 4, 2025
src/urllib3/response.py
Outdated
| @@ -1073,6 +1076,10 @@ def readable(self) -> bool: | |||
| return True | |||
|
|
|||
| def shutdown(self) -> None: | |||
| if self._released_conn: | |||
There was a problem hiding this comment.
Suggested change
| if self._released_conn: | |
| if not self._connection: |
There's no need for an extra attribute here.
There was a problem hiding this comment.
@D-stefaang Thank you for the review. I have removed the extra attribute now.
pquentin
reviewed
May 30, 2025
|
|
||
|
|
||
| class TestShutdownOnConnectionReleasedToPool(HypercornDummyServerTestCase): | ||
| def test_shutdown_on_connection_released_to_pool(self) -> None: |
There was a problem hiding this comment.
Can you please move this test to be after test_cleanup_on_connection_error? We don't want to many HypercornDummyServerTestCase as they start a new server each time.
There was a problem hiding this comment.
@pquentin Thank you for your review. I have moved the new test to be after test_cleanup_on_connection_error.
pquentin
approved these changes
Jun 15, 2025
|
@pquentin Thank you for the opportunity to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3581