-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix emscripten CI for Chrome 137+ #3599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into fix_chrome137
@illia-v I think this is ready to go now I got rid of the silly test code in fetch.py |
@joemarshall thanks for the efforts to fix the CI! |
On second thought, I'm ready to merge this with a couple of minor changes. There is still some refactoring I'd like to do on top of this, but it can be done separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why we need pyodide.ffi.can_run_sync = lambda: False
twice, but it does fix CI.
I believe one patches tests using web workers and another for tests running in the main thread |
Fix to the CI errors occurring in Chrome 137 or later, because JSPI is on by default in those browsers.
#3598