Skip to content

fixed bug in emscripten requests #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 25, 2025
Merged

Conversation

joemarshall
Copy link
Contributor

Fix for #3555

@joemarshall joemarshall marked this pull request as ready for review January 29, 2025 15:18
@joemarshall
Copy link
Contributor Author

Should be fixed now.

Copy link
Member

@illia-v illia-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@joemarshall
Copy link
Contributor Author

@illia-v

I think I addressed all the comments here. Sorry for the delay.

@illia-v illia-v linked an issue Feb 25, 2025 that may be closed by this pull request
@illia-v
Copy link
Member

illia-v commented Feb 25, 2025

The PyPy tests fail in other branches too, the error needs separate investigating

@illia-v illia-v merged commit 93ebfc1 into urllib3:main Feb 25, 2025
34 of 36 checks passed
@joemarshall joemarshall deleted the requestsfix branch February 26, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emscripten bug with partial reads
2 participants