-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add HTTPSConnection.proxy_is_tunneling #3459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the suggestion and add a changelog entry
Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
@Mr-Sunglasses thanks for accepting the suggestion, please add a changelog entry |
Sure @illia-v |
@illia-v I've added the changelog, LMK if anything more to do with this PR. And thanks a lot for reviewing this PR 🙏, |
2.12.904 (2024-12-22) ===================== - Fixed an issue when trying to force load Websocket over HTTP/2 or HTTP/3. - Ensured WebSocket via HTTP/2 with improved CI pipeline featuring haproxy as the reverse proxy. - Fixed ``RuntimeError`` when forcing HTTP/3 by disabling both HTTP/1, and HTTP/2 and the remote is unable to negotiate HTTP/3. This issue occurred because of our automatic downgrade procedure introduced in our 2.10.x series. The downgrade ends in panic due to unavailable lower protocols. This only improve the UX by not downgrading and letting the original error out. See jawah/niquests#189 for original user report. - Fixed negotiated extensions for WebSocket being ignored (e.g. per-deflate message). - Backported ``HTTPResponse.shutdown()`` and nullified it. The fix they attempt to ship only concern them, we are already safe (based on issue reproduction). See urllib3#2868 - Backported ``proxy_is_tunneling`` property to ``HTTPConnection`` and ``HTTPSConnection``. See urllib3#3459 - Backported ``HTTPSConnection.is_verified`` to False when using a forwarding proxy. See urllib3#3283 - Backported pickling support to ``NewConnectionError`` and ``NameResolutionError``. See urllib3#3480
fix: #3285