Skip to content

Conversation

Mr-Sunglasses
Copy link
Contributor

@Mr-Sunglasses Mr-Sunglasses commented Aug 23, 2024

fix: #3285

Copy link
Member

@illia-v illia-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the suggestion and add a changelog entry

Mr-Sunglasses and others added 2 commits September 29, 2024 14:27
Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
@sethmlarson sethmlarson requested a review from illia-v September 30, 2024 16:55
@illia-v
Copy link
Member

illia-v commented Sep 30, 2024

@Mr-Sunglasses thanks for accepting the suggestion, please add a changelog entry

@Mr-Sunglasses
Copy link
Contributor Author

@Mr-Sunglasses thanks for accepting the suggestion, please add a changelog entry

Sure @illia-v

@Mr-Sunglasses
Copy link
Contributor Author

@illia-v I've added the changelog, LMK if anything more to do with this PR.

And thanks a lot for reviewing this PR 🙏,

@illia-v illia-v merged commit 7783dbd into urllib3:main Oct 2, 2024
34 checks passed
Ousret added a commit to jawah/urllib3.future that referenced this pull request Dec 22, 2024
2.12.904 (2024-12-22)
=====================

- Fixed an issue when trying to force load Websocket over HTTP/2 or
HTTP/3.
- Ensured WebSocket via HTTP/2 with improved CI pipeline featuring
haproxy as the reverse proxy.
- Fixed ``RuntimeError`` when forcing HTTP/3 by disabling both HTTP/1,
and HTTP/2 and the remote is unable to negotiate HTTP/3.
This issue occurred because of our automatic downgrade procedure
introduced in our 2.10.x series. The downgrade ends in panic
due to unavailable lower protocols. This only improve the UX by not
downgrading and letting the original error out.
See jawah/niquests#189 for original user
report.
- Fixed negotiated extensions for WebSocket being ignored (e.g.
per-deflate message).
- Backported ``HTTPResponse.shutdown()`` and nullified it. The fix they
attempt to ship only concern
them, we are already safe (based on issue reproduction). See
urllib3#2868
- Backported ``proxy_is_tunneling`` property to ``HTTPConnection`` and
``HTTPSConnection``.
  See urllib3#3459
- Backported ``HTTPSConnection.is_verified`` to False when using a
forwarding proxy.
  See urllib3#3283
- Backported pickling support to ``NewConnectionError`` and
``NameResolutionError``.
  See urllib3#3480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a property for proxy_is_tunnel
2 participants