Skip to content

Added support for HTTP/2 chunked request bodies #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2024
Merged

Added support for HTTP/2 chunked request bodies #3441

merged 4 commits into from
Aug 11, 2024

Conversation

alexprabhat99
Copy link
Contributor

Closes: #3425

@alexprabhat99
Copy link
Contributor Author

alexprabhat99 commented Aug 5, 2024 •
edited
Loading

Hi @sethmlarson , @illia-v , @pquentin
I looked at the code and saw that we already ignore the "chunked" parameter. If Transfer-Encoding: chunked is there in the headers, it is skipped by this PR's changes, and the body is sent without the chunked framing. I have added a test as well for this behavior. Please let me know if this works.
Thank you.

pquentin
pquentin approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin pquentin merged commit d494c47 into urllib3:main Aug 11, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for HTTP/2 chunked request bodies
2 participants
@alexprabhat99 @pquentin