Fish completions tests invokes setup #2124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the completions to depend on parent-child relations, making several method signatures simpler.
dearchap
approved these changes
May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR updates fish completions test suite to invoke
setupCommandGraph(). This make the fish completion tests more realistic since ordinary execution will have performed this setup. Help commands that were removed in #2121 will now be generated the "correct" way in tests.This also allows us to clean up helper method signatures by depending on command parent-child relations for various information needs. Since we are now juggling even more
Commandobjects, I chose to make the helpers into free functions so there is no confusion with "self".Finally, subcommand aliases are no longer listed as suggestions, only the canonical name. Completions after aliases still work as normal.
Which issue(s) this PR fixes:
None, but the cleanup prepares the way for #2115.
Special notes for your reviewer:
Best reviewed commit-by-commit.
Release Notes