Skip to content

[Backport] Fix: Use $0 env var to correctly retrieve the current active shell #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2024
Merged

[Backport] Fix: Use $0 env var to correctly retrieve the current active shell #1970

merged 1 commit into from
Aug 22, 2024

Conversation

asahasrabuddhe
Copy link
Member

What type of PR is this?

This is a backport for #1969 which fixes #1884

Release Notes

Fixes #1884 - Shell completions are broken when the login shell is different than the currently active shell.

@asahasrabuddhe asahasrabuddhe requested a review from a team as a code owner August 21, 2024 12:19
@asahasrabuddhe asahasrabuddhe merged commit bcc6869 into urfave:v2-maint Aug 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dearchap dearchap dearchap approved these changes

@Juneezee Juneezee Juneezee approved these changes

@bartekpacia bartekpacia bartekpacia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asahasrabuddhe @dearchap @Juneezee @bartekpacia