Skip to content

Conversation

dearchap
Copy link
Contributor

What type of PR is this?

  • feature

What this PR does / why we need it:

Add support for uint64 slices

Which issue(s) this PR fixes:

Special notes for your reviewer:

Please focus on altsrc changes as well, especially the type switch

Testing

Ran unit tests

Release Notes

Add support for uint64slice flag 

@dearchap dearchap requested a review from a team as a code owner April 26, 2022 23:15
Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! 🎉 I noticed one bit of what I assume was leftover debugging and I think the new json altsrc stuff should definitely be covered by tests 👍🏼

@dearchap dearchap requested a review from meatballhat April 28, 2022 23:58
@meatballhat meatballhat added this to the Release 2.x milestone May 8, 2022
@meatballhat meatballhat added kind/feature describes a code enhancement / feature request area/v2 relates to / is being considered for v2 status/conflicts contains merge conflicts labels May 8, 2022
@meatballhat
Copy link
Member

@dearchap Are you up for addressing the conflicts and getting the test coverage above the threshold? No worries if not. I'm happy to take this work to completion.

@dearchap
Copy link
Contributor Author

dearchap commented Jul 5, 2022

@meatballhat Let me take a look

@dearchap dearchap dismissed stale reviews from ghost via da66c9d August 13, 2022 01:57
@dearchap
Copy link
Contributor Author

@meatballhat Done. Can you take a look ?

@dearchap dearchap removed the status/conflicts contains merge conflicts label Aug 15, 2022
@dearchap
Copy link
Contributor Author

@meatballhat Can you take a look at why tests are failing ? I dont quite understand why.

@meatballhat
Copy link
Member

meatballhat commented Sep 5, 2022

@dearchap looks like tests are happy now -- coverage thresholds are still grumpy, but I don't want to be draconian about those checks. Maybe add some coverage threshold wiggle room as part of this PR? e.g.:

# in .github/codecov.yml
coverage:
  threshold: 5%

@dearchap
Copy link
Contributor Author

dearchap commented Sep 6, 2022

@meatballhat I update the coverage threshold but it still fails. Can you approve and merge ?

@Dokiys
Copy link
Member

Dokiys commented Sep 8, 2022

@meatballhat Can you take a look at why tests are failing ? I dont quite understand why.

@dearchap codecov will use the coverage from the base commit. Checks show target coverage need 83.22. You can try this specify a target.
Would 5% be too low? I feel more coverage can reduce review time.

@meatballhat meatballhat mentioned this pull request Oct 2, 2022
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/feature describes a code enhancement / feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants