-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Feature:(Issue 1334) Add support for uint64slices #1378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! 🎉 I noticed one bit of what I assume was leftover debugging and I think the new json altsrc stuff should definitely be covered by tests 👍🏼
@dearchap Are you up for addressing the conflicts and getting the test coverage above the threshold? No worries if not. I'm happy to take this work to completion. |
@meatballhat Let me take a look |
@meatballhat Done. Can you take a look ? |
@meatballhat Can you take a look at why tests are failing ? I dont quite understand why. |
@dearchap looks like tests are happy now -- coverage thresholds are still grumpy, but I don't want to be draconian about those checks. Maybe add some coverage threshold wiggle room as part of this PR? e.g.: # in .github/codecov.yml
coverage:
threshold: 5% |
@meatballhat I update the coverage threshold but it still fails. Can you approve and merge ? |
@dearchap codecov will use the coverage from the base commit. Checks show target coverage need 83.22. You can try this specify a target. |
What type of PR is this?
What this PR does / why we need it:
Add support for uint64 slices
Which issue(s) this PR fixes:
Special notes for your reviewer:
Please focus on altsrc changes as well, especially the type switch
Testing
Ran unit tests
Release Notes