-
-
Notifications
You must be signed in to change notification settings - Fork 99
githubaction autodiscovery should allow for pinning version to commit hash #3508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
fe8d985
to
632ff8c
Compare
7c4c2dd
to
7b640f6
Compare
7b640f6
to
8bfd7ec
Compare
8c2cb4c
to
0342d27
Compare
|
olblak
reviewed
Jan 9, 2025
9097a51
to
da11f17
Compare
olblak
reviewed
Jan 11, 2025
olblak
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment but the pullrequest is ready to be merged with or without my suggestion
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3507
Introduce a
key
argument for github release to get the tag hash instead of the tag name.Test
To test this pull request, you can run the following commands:
Additional Information
This pr introduces the following changes:
githubrelease
now supports ankey
argument likegittag
that can either bename
(default) orhash
.gitbranch
now supports ankey
argument likegittag
that can either bename
(default) orhash
.yaml
now accept acomment
arg, when used in atarget
and with theyamlpath
engine, it can be used to add a comment to a line.Yaml comment
Given the following
test.yaml
Running
updatecli.yaml
Would yield
test.yaml
githubaction
autodiscovery can be setup to resolveddigest
:gets resolved to
The comment is required to be able to infer the update channel in the following updates, removing it would translate to a pinned version.