Skip to content

feat: add Dasel v2 support for the JSON plugin #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025

Conversation

olblak
Copy link
Member

@olblak olblak commented Jul 30, 2025

Fix #5750

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/json/
go test

Additional Information

Checklist

  • I have updated the documentation via pull request in website repository.

I made some comment refactoring to improve documentation based on the jsonschema

Tradeoff

Potential improvement

Probably worth to improve the toml plugin as well in a separated PR

@olblak olblak added enhancement New feature or request resource-json labels Jul 30, 2025
dduportal
dduportal previously approved these changes Jul 30, 2025
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olblak olblak merged commit 59ae32c into updatecli:main Jul 30, 2025
6 checks passed
@olblak olblak deleted the issue/5750 branch July 30, 2025 14:27
@theletterf
Copy link

This is fantastic. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resource-json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to pick last item of a JSON array?
3 participants